[Webkit-unassigned] [Bug 143521] [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 8 07:50:59 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=143521
--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 250347
--> https://bugs.webkit.org/attachment.cgi?id=250347
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=250347&action=review
>> Source/WebCore/bindings/gobject/DOMObjectCache.cpp:48
>> + cacheReferences = std::min(static_cast<unsigned>(object->ref_count), cacheReferences);
>
> It might be worth dropping a comment here explaining why cacheReferences might be incorrect at this point.
Also, coulnd't we completely forget about cacheReferences and simply use GObject's ref_count ?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150408/7c1546cf/attachment.html>
More information about the webkit-unassigned
mailing list