[Webkit-unassigned] [Bug 143488] Animation is not stopped when animation class is removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143488

--- Comment #1 from Eduard Kegulskiy <ed_dvd at yahoo.com> ---
The problem seems to be in GraphicsLayerTextureMapper class.

Specifically, when animation is added, the GraphicsLayerTextureMapper::addAnimation() is called which does 2 things:
1. add new animation to m_animations set
2. calls notifyChange(AnimationChange) to notify m_layer that its own internal set of animations has been modified.

However, when animation is removed via GraphicsLayerTextureMapper::removeAnimation(), the code only removes the animation from the m_animations set, but does not notify the m_layer.

The proposed patch would be to add notifyChange(AnimationChange) call to both removeAnimation() and pauseAnimation() as following:

void GraphicsLayerTextureMapper::pauseAnimation(const String& animationName, double timeOffset)
{
    m_animations.pause(animationName, timeOffset);
    notifyChange(AnimationChange);
}

void GraphicsLayerTextureMapper::removeAnimation(const String& animationName)
{
    m_animations.remove(animationName);
    notifyChange(AnimationChange);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150407/fd8a8686/attachment.html>