[Webkit-unassigned] [Bug 143480] [GStreamer] extra-headers and keep-alive properties for HTTP source element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143480

--- Comment #5 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 250265
  --> https://bugs.webkit.org/attachment.cgi?id=250265
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250265&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:504
>> +                return FALSE;
> 
> Do we want to return if any of the elements fail, or should we try with the rest?

This code is inspired from gst's souphttpsrc element, I'd rather avoid a different behavior here.

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:511
>> +                return FALSE;
> 
> Do we want to return if any of the elements fail, or should we try with the rest?

This code is inspired from gst's souphttpsrc element, I'd rather avoid a different behavior here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150407/ee172c78/attachment.html>