[Webkit-unassigned] [Bug 143433] New: Web Inspector: wrap style class names in WebInspector.StyleClass helper

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143433

            Bug ID: 143433
           Summary: Web Inspector: wrap style class names in
                    WebInspector.StyleClass helper
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: burg at cs.washington.edu
                CC: graouts at webkit.org, joepeck at webkit.org,
                    jonowells at apple.com, mattbaker at apple.com,
                    nvasilyev at apple.com, timothy at apple.com,
                    webkit-bug-importer at group.apple.com

Since we are moving away from long-winded style properties on view constructors, here's an idea. Given the two following approaches:

this.element.classList.add("inline-object-foo")

this.element.classList.add(WebInspector.StyleClass("inline-object-foo"))

The latter supports tooling to check for bogus style names.

* This could be done mostly at compile-time by cross-checking against identifiers in CSS files.
* Alternatively, in engineering builds we could collate a "style class whitelist" similar to localizedStrings.js. At runtime we do a lookup into the whitelist and log an error if a bogus style class is used. In production builds, use sed to remove the unnecessary lookup.

Thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150406/75d41a27/attachment.html>