[Webkit-unassigned] [Bug 142887] role progress bar does not support indeterminate state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142887

--- Comment #7 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 250124
  --> https://bugs.webkit.org/attachment.cgi?id=250124
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250124&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2501
>          return [NSNumber numberWithFloat:m_object->minValueForRange()];

don't we need to do the same thing for the min value for indeterminate items?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2506
> +            return [NSNumber numberWithFloat:0.0f];

this can be written as
@0

> LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt:8
> +PASS prog1.maxValue is 0

i think we need to test the min value too right

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150404/dfa41678/attachment-0001.html>