[Webkit-unassigned] [Bug 143387] Improvements to webkitmouseforce web API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143387

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250103|review?                     |review+
              Flags|                            |

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 250103
  --> https://bugs.webkit.org/attachment.cgi?id=250103
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250103&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:345
> +    , m_lastForceStage(0)

No need to initialize here if you take my suggestion below.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1348
> +    int m_lastForceStage;

Better to initialize this here:

    int m_lastForceStage { 0 };

or even:

    int m_lastForceStage { };

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1168
> +    float overallForce = stage < 1 ? force : force + stage - 1;

I guess the force number is in the range [0,1]? Should we assert that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150403/c658adfc/attachment.html>