[Webkit-unassigned] [Bug 143387] Improvements to webkitmouseforce web API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143387

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 250099 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250099&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:992
> > +    void pressureDidChange(float force, int stage);
> 
> Some indication of what kind of pressure or what you're talking about at all
> might be good :D mousePressureDidChange? No idea.
> 
> Also why is it pressure and force?
> 

The NSResponder method uses the term "pressure," which is why I used it here. Maybe we shouldn't let that spread into our code? But for the time being I used it to keep it more directly tied to the NSResponder method of that name.

> > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1171
> > +    if (m_lastPressureEventForceStage == 1 && stage == 2)
> 
> Isn't the negativity of stageTransition how you're supposed to figure out
> which direction you're going? Can we totally avoid caching the old one in
> that case?

stageTransition is not consistent for this purpose as far as I can tell.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150403/3c2278f4/attachment-0001.html>