[Webkit-unassigned] [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128177





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-09-30 17:16:08 PST ---
(From update of attachment 238932)
View in context: https://bugs.webkit.org/attachment.cgi?id=238932&action=review

> ChangeLog:9
> +        using CustomProtocols implementation from Carlos Garcia Campos

Revision number is more helpful than patch owner name.

> Source/WebKit2/ChangeLog:9
> +        using CustomProtocols implementation from Carlos Garcia Campos

ditto.

> Source/WebKit2/PlatformEfl.cmake:229
> +    "${WEBKIT2_DIR}/Shared/Network/CustomProtocols/soup"

Wrong alphabet order.

> Source/cmake/OptionsEfl.cmake:311
> +add_definitions(-DENABLE_CUSTOM_PROTOCOLS=1)

Please add CUSTOM_PROTOCOLS definitions to WebKitFeatures.cmake.

> Tools/MiniBrowser/efl/main.c:75
> +static void about_url_scheme_request_cb(Ewk_Url_Scheme_Request *request, void *user_data)

*about* looks like a redundant prefix.

> Tools/MiniBrowser/efl/main.c:84
> +        // Todo

Use //FIXME:

> Tools/MiniBrowser/efl/main.c:87
> +        // Todo

ditto.

> Tools/MiniBrowser/efl/main.c:90
> +        // Todo

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.