[Webkit-unassigned] [Bug 63290] Stack overflow with enormous SVG filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63290


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238892|review?                     |review+
               Flag|                            |




--- Comment #28 from Dean Jackson <dino at apple.com>  2014-09-30 12:31:07 PST ---
(From update of attachment 238892)
View in context: https://bugs.webkit.org/attachment.cgi?id=238892&action=review

Looks great. Minor comments. Upload a new patch and we'll land this!!

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:107
> +unsigned FilterEffect::collectEffects(const FilterEffect*effect, HashSet<const FilterEffect*>& allEffects)

This could be a static function just in this file, not in the class.

> Source/WebCore/platform/graphics/filters/FilterEffect.h:82
> +    static unsigned collectEffects(const FilterEffect*, HashSet<const FilterEffect*>&);

No need for this if we just declare it in the .cpp.

> LayoutTests/ChangeLog:13
> +        Test if an SVG filter with deeply nested tree of FilterEffects can be loaded
> +        with no crash.  Make sure other valid filters can still be referenced by SVG 
> +        drawing elements.
> +
> +        * svg/filters/svg-deeply-nested-crash-expected.txt: Added.
> +        * svg/filters/svg-deeply-nested-crash.html: Added.

Now we should have one more test that is the <200 but >100 case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.