[Webkit-unassigned] [Bug 137170] REGRESSION (r172532): JSBase.h declares NSMapTable functions that are SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 30 10:14:40 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137170





--- Comment #2 from Daniel Bates <dbates at webkit.org>  2014-09-30 10:14:37 PST ---
(In reply to comment #1)
> Can those declarations be in the prefix header instead?

I could move those declarations to the prefix header. I plan to move the forward declarations for XPC SPI that we use in JavaScriptCore (*) to a file in WTF/wtf/spi (so that they can be shared with projects JavaScriptCore, WebCore, and WebKit). As we discussed in-person today (09/30), I propose moving these declarations to WTF/wtf/spi/NSMapTableSPI.h for consistency. This would also make it straight forward to use NSMapTable SPI in other projects in the future (by including WTF/wtf/spi/NSMapTableSPI.h).

(*) For instance, <http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/inspector/remote/RemoteInspector.mm?rev=174028#L41>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list