[Webkit-unassigned] [Bug 137110] [GTK] Implement is_selected method on WebKitHitTestResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137110


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238843|review?                     |review-
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-29 03:44:29 PST ---
(From update of attachment 238843)
View in context: https://bugs.webkit.org/attachment.cgi?id=238843&action=review

Thanks for the patch, it looks good to me in general, but new API patches should include a unit test (see Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp and TestContextMenu.cpp). Also this patch changes cross-platform code, so it requires the approval of a WebKit2 owner.

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:366
> + */

Since: 2.8

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.h:51
> + * @WEBKIT_HIT_TEST_RESULT_CONTEXT_SELECTION: a selected element.

Since: 2.8.

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.h:100
> +webkit_hit_test_result_context_is_selection  (WebKitHitTestResult *hit_test_result);

I think there's an extra space between function name and parentheses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.