[Webkit-unassigned] [Bug 131707] Simple ES6 feature: Number constructor extras

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131707





--- Comment #38 from Diego Pino <dpino at igalia.com>  2014-09-29 02:33:56 PST ---
(In reply to comment #37)
> (From update of attachment 238769 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238769&action=review
> 
> > Source/JavaScriptCore/runtime/CommonIdentifiers.h:125
> > +    macro(isFinite) \
> > +    macro(isInteger) \
> > +    macro(isNaN) \
> >      macro(isPrototypeOf) \
> > +    macro(isSafeInteger) \
> 
> Wait, why are we adding these? I don’t think this change should have been included in the patch.
> 
> > Source/JavaScriptCore/runtime/CommonIdentifiers.h:148
> > +    macro(parseFloat) \
> > +    macro(parseInt) \
> 
> Ditto.

Sorry, my fault. I created a new bug fixing this issue and adding tests for Number.parseFloat(undefined) and Number.parseInt(undefined).

https://bugs.webkit.org/show_bug.cgi?id=137206

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.