[Webkit-unassigned] [Bug 30322] WebCore level persistent caching

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 08:39:04 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=30322





--- Comment #7 from WebKit Commit Bot <commit-queue at webkit.org>  2014-09-25 08:39:02 PST ---
Attachment 238659 did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.mm:49:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.mm:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.mm:351:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.mm:374:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.mm:389:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:63:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:95:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkCacheStorage.h:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.h:67:  The parameter name "entry" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:78:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:79:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:85:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:169:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:188:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkCache.cpp:201:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:152:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:155:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:292:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:514:  Use 'WTF::move()' instead of 'std::move()'.  [runtime/wtf_move] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:73:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:80:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 29 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list