[Webkit-unassigned] [Bug 137116] [GTK] Add selection-changed signal to the WebKit2 API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 06:02:46 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137116





--- Comment #5 from Tomas Popela <tpopela at redhat.com>  2014-09-25 06:02:46 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > > Source/WebKit2/ChangeLog:9
> > > > +        Add the selection-changed signal into the WebKit2 GTK+ API. This
> > > > +        signal will be emitted everytime the selection in page is changed.
> > > 
> > > What's the use case? what does evo do when the selection changes?
> > Basically the whole UI (all buttons regarding the formatting (ie. bold font, block format)) is operating on callback on this signal. So when user is moving with the caret through the content of the composer the UI is updated accordingly (it also applies situations where some content is selected).
> 
> So, this sounds like you need that in the UI process then.
OK, let's move it there. I will update the patch with previous recommendations.
> 
> > > > Source/WebKit2/ChangeLog:14
> > > > +        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
> > > > +        (didChangeSelection):
> > > > +        (webkit_web_page_class_init):
> > > > +        (webkitWebPageCreate):
> > > 
> > > Why do you need this in the web extensions API?
> > 
> > Hm it was mostly selfish decision (at least regarding to the Evolution) as we are doing various operations above DOM to get the actual state of content format (ie. is this paragraph indented, size of font, format of the block ..).
> 
> Would it be possible to do the same by exposing the EditorState in the UI process API?

For some things yes (font properties, ...) but for some not as some of them depend on other things (DOM structure, class names, ...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list