[Webkit-unassigned] [Bug 137116] [GTK] Add selection-changed signal to the WebKit2 API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137116


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238655|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-25 05:14:36 PST ---
(From update of attachment 238655)
View in context: https://bugs.webkit.org/attachment.cgi?id=238655&action=review

Thanks for the patch, but new API should include a unit test.

> Source/WebKit2/ChangeLog:9
> +        Add the selection-changed signal into the WebKit2 GTK+ API. This
> +        signal will be emitted everytime the selection in page is changed.

What's the use case? what does evo do when the selection changes?

> Source/WebKit2/ChangeLog:14
> +        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
> +        (didChangeSelection):
> +        (webkit_web_page_class_init):
> +        (webkitWebPageCreate):

Why do you need this in the web extensions API?

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:289
> +     */

Since: 2.8

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:294
> +        0, 0, 0,

0, nullptr, nullptr,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.