[Webkit-unassigned] [Bug 136945] ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136945


Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238652|review?                     |review+
               Flag|                            |




--- Comment #2 from Sergio Villar Senin <svillar at igalia.com>  2014-09-25 04:04:48 PST ---
(From update of attachment 238652)
View in context: https://bugs.webkit.org/attachment.cgi?id=238652&action=review

> Source/WebCore/css/CSSParser.cpp:5571
> +    if (gridRowNames.isEmpty() || gridRowNames.containsOnlyWhitespace())

Does this cover also multiple whitespaces?

> LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash-expected.txt:1
> +crbug.com/412715 - ASSERTION FAILED: columnCount in blink::CSSPropertyParser::parseGridTemplateAreasRow

Do not mention external bugs. Also remove the blink:: thing

> LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash.html:27
> +<p>crbug.com/412715 - ASSERTION FAILED: columnCount in blink::CSSPropertyParser::parseGridTemplateAreasRow</p>

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.