[Webkit-unassigned] [Bug 21562] Layering violation: MediaPlayer should not reference/use FrameView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 03:58:20 PDT 2014


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
            Summary|Layering violation:         |Layering violation:
                   |MediaPlayer should not      |MediaPlayer should not
                   |reference/use               |reference/use FrameView
                   |CachedResourceLoader        |

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-25 03:58:18 PST ---
(In reply to comment #1)
> Updated bug title, since the MediaPlayer no longer uses FrameView, I think the only layering violation remaining is the CachedResourceLoader.

Oops, I was wrong, MediaPlayer still uses FrameView. I've been checking it and it's easy to fix for most of the cases. 

 - When checking whether the player has a frame view, we can simply check whether it's visible, because it's equivalent.
 - To check if the player is in a media document, we can add another virtual method to MediaPlayerClient, that HTMLMediaElement can implement just with return document().isMediaDocument()
 - MediaPlayerPrivateQTKit also uses it to get the ColorSpace and Font in order to render the frame rate. I wonder if we could pass those somehow from RenderVideo, or add a MediaPlayer::paintFrameRate(ColorSpace, Font) called after paint() by RenderVideo, and implemented only by MediaPlayerPrivateQTKit. Another approach would be to add media player methods to get the colorspace and font, implemented by the HTMLMediaElement.
 - And finally it's used again by MediaPlayerPrivateQTKit to make the QTMovieView a subview of the document view. I have no idea what this means.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list