[Webkit-unassigned] [Bug 133344] [GTK] Adds implementation of subtle crypto AES-CBC algorithm
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 24 00:49:16 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=133344
Philippe Normand <pnormand at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #238545|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #5 from Philippe Normand <pnormand at igalia.com> 2014-09-24 00:49:14 PST ---
(From update of attachment 238545)
View in context: https://bugs.webkit.org/attachment.cgi?id=238545&action=review
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:39
> +static gnutls_cipher_hd_t createCipher(const CryptoAlgorithmAesCbcParams& parameters, const CryptoKeyAES& key, gnutls_cipher_algorithm_t *algorithm)
Misplaced * :) Also perhaps a smart pointer could be used instead of a raw pointer here.
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:51
> + gnutlsKey.data = (unsigned char*) key.key().data();
We avoid C-style casts in WebCore, here I think a reinterpret_cast might work.
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:55
> + gnutlsIv.data = (unsigned char*) parameters.iv.data();
Ditto
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:68
> + gnutls_cipher_algorithm_t algo;
algorithm
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:71
> + failureCallback();
No need to set ExceptionCode here?
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:90
> + failureCallback();
No need to set ExceptionCode here?
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:104
> + failureCallback();
No need to set ExceptionCode here?
> Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp:112
> +void CryptoAlgorithmAES_CBC::platformDecrypt(const CryptoAlgorithmAesCbcParams& parameters, const CryptoKeyAES& key, const CryptoOperationData& data, VectorCallback callback, VoidCallback failureCallback, ExceptionCode&)
Same comments as in previous method
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list