[Webkit-unassigned] [Bug 137025] New: HTMLMediaElement::removedFrom is not clearing the player and causes lock up of video resource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137025

           Summary: HTMLMediaElement::removedFrom is not clearing the
                    player and causes lock up of video resource
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: thouraya.andolsi at st.com


Hi,

Calling HTMLMediaElement::removedFrom() function in
"Source/WebCore/html/HTMLMediaElement.cpp" file will only pause the video.

But this leads to lock up of video resource when we are playing video in Hardware mode.
We should explicitly call m_player.clear() to clear the mediaplayer as follows.

diff --git a/qtwebkit/Source/WebCore/html/HTMLMediaElement.cpp b/qtwebkit/Source/WebCore/html/HTMLMediaElement.cpp
index 314a85d..1e706f1 100644
--- a/qtwebkit/Source/WebCore/html/HTMLMediaElement.cpp
+++ b/qtwebkit/Source/WebCore/html/HTMLMediaElement.cpp
@@ -540,6 +540,7 @@ void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint)
             pause();
         if (m_isFullscreen)
             exitFullscreen();
+        m_player.clear();
     }

     HTMLElement::removedFrom(insertionPoint);




Is this the right way to do it?
otherwise, how to fix the issue?


Regards,
Thouraya.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.