[Webkit-unassigned] [Bug 136854] [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136854





--- Comment #9 from Rohit <kumar.rohit at samsung.com>  2014-09-23 06:23:23 PST ---
(In reply to comment #8)
> (From update of attachment 238468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238468&action=review
> 
> > Tools/ChangeLog:9
> > +        ewk_view_fullscreen_exit(ewk_view) doesn't work as ewk_view does not know that it has gone fullscreen.
> > +        We use elm_win_fullscreen_set to toggle fullscreen and elm_window has fullscreen state information, and not the ewk_view.
> > +        There is no specific API calls to enter fullscreen for ewk_view. So either we need to add API for enter fullscreen or remove ewk_view_fullscreen_exit.
> 
> Sorry for late comment.
> 
> But, I think that this comment looks wrong.
> 
> This issue is the bug of MiniBrowser.
> ewk_view_fullscreen_exit() is to notify the changes of state to ewk_view when user cancelled HTML5's fullscreen API.
> For example, w3c fullscreen API can make specific element as full screen (ex, video element).
> So, ewk_view should know the exit to restore the web contents from specific element to whole contents when user cancelled requests of w3c fullscreen.
> 
> I think that MiniBrowser should distinguish which events started current full screen status, w3c's fullscreen API or shortcut(F11)

Thanks for the insight. It makes sense. On observing behaviours for other broswers, I found that 'Esc'is used only for exiting fullscreen when a specific element is fullscreen and not in case of window fullscreen. In case when browser window is fullscreen, F11 is used to exit fullscreen. However, F11 can be used to exit fullscreen even when a window element has gone fullscreen as specific element makes window go fullscreen along with it. I will submit the modified patch based on this observation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.