[Webkit-unassigned] [Bug 133320] [GTK] Adds implementation of subtle crypto HMAC algorithm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 22 02:20:29 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133320


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236507|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Philippe Normand <pnormand at igalia.com>  2014-09-22 02:20:29 PST ---
(From update of attachment 236507)
View in context: https://bugs.webkit.org/attachment.cgi?id=236507&action=review

Looks good! Only a small nit to fix, I think

> Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:99
> +    callback(result);}

Is this a spurious curly brace?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list