[Webkit-unassigned] [Bug 136632] Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 19 01:58:40 PDT 2014


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
         Depends on|                            |136943

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-19 01:58:40 PST ---
(In reply to comment #9)
> (From update of attachment 238246 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238246&action=review
> > Source/WebKit2/PlatformGTK.cmake:-386
> > -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.png
> > -    ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/*.svg
> This is not enough, these files are only to make the dependencies in the build system, but what we pass to generate-inspector-gresource-manifest.py is ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/ that is walked finding files with extensions html, js, css, png or svg. So, we need to remove the png and svg extensions from the list of valid extensions in generate-inspector-gresource-manifest.py.

The patch in bug #136943 will make this patch work, and will allow us to ignore the apple icons once we have ours.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list