[Webkit-unassigned] [Bug 136923] [GTK] Dot not allow to create delete-on-destroy GMainLoopSources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136923


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238310|review?                     |review+
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2014-09-18 13:08:47 PST ---
(From update of attachment 238310)
View in context: https://bugs.webkit.org/attachment.cgi?id=238310&action=review

> Source/WTF/wtf/gobject/GMainLoopSource.cpp:36
> -GMainLoopSource& GMainLoopSource::createAndDeleteOnDestroy()
> +GMainLoopSource& GMainLoopSource::create()

I think this name should be kept, otherwise it may lead people to believe that this is the default or only way of creating, like on other objects, it gets confusing.

> Source/WTF/wtf/gobject/GMainLoopSource.cpp:-85
> -    // Delete-on-destroy GMainLoopSource objects can only be cancelled when there's callback either scheduled
> -    // or in the middle of dispatch. At that point cancellation will have no effect.
> -    ASSERT(m_deleteOnDestroy != DeleteOnDestroy || (m_status == Ready && !m_context.source));

Heh, this was a bit weird.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.