[Webkit-unassigned] [Bug 136892] New: Aways have a PageThrottler (sometimes have a UserActivity::Impl)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 10:47:11 PDT 2014


           Summary: Aways have a PageThrottler (sometimes have a
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com

Some instances of Page have a PageThrottler to track activity on the Page, and some do not. (Specifically, those created from WebPage in WK2 do, those related to WK1, SVG & inspector do not).

We do this for three reasons:
    • We do not need to take AppNap assertions on WK1.
    • Some Pages do not track their visibility correctly, and would always claim to be visible.
    • Page VisibilityState is not set until after construction, so if we instantiate 

Creating the entire PageThrottler lazily has the drawback that we have to check for its existence at numerous points throughout the code, and we'll miss activity that occurs between the Page being created & the PageThrottler added to it (really a theoretical problem right now, since they're currently always created pretty much back to back).

Instead, Page should always have a PageThrottler, & instead make the UserActivity::Impl on the PageThrottler be added later.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list