[Webkit-unassigned] [Bug 136889] New: [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136889

           Summary: [GTK] WebKitWebView::load-failed-with-tls-errors
                    should receive the failing URI instead of a host
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cgarcia at igalia.com
                CC: gns at gnome.org, svillar at igalia.com,
                    mcatanzaro at gnome.org


We were passing a host for two different reasons, first because it's more convenient to add an exception with webkit_web_context_allow_tls_certificate_for_host(), but also because we were assuming the active URI is the failing URI in case of failure. This assumption is correct because our current code does that, but I'm not sure we are doing it on purpose. That behaviour is not documented anywhere (see http://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#webkit-web-view-get-uri), it's not what WebKit2 does internaly (see https://bugs.webkit.org/show_bug.cgi?id=136526#c2) and it's not even what epiphany assumes (see https://git.gnome.org/browse/epiphany/tree/embed/ephy-web-view.c?id=3.13.91#n1986). WebKitWebView::load-failed passes the failing URI as parameter, that wouldn't be needed if the active URI was the failing URI. 
This API has already been changed in this cycle and it's considered to be new in 2.6, so this new change is not a problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.