[Webkit-unassigned] [Bug 136739] [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 01:50:01 PDT 2014


--- Comment #4 from Tanay <tanay.c at samsung.com>  2014-09-17 01:50:03 PST ---
(In reply to comment #2)
> (From update of attachment 238105 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238105&action=review
> > Tools/MiniBrowser/efl/main.c:312
> > +        if (ev->z == -1 && zoom_level_set(ewk_view, window->current_zoom_level + 1)) {
> Isn't ewk_view same with window->ewk_view ? If so, how about using window->ewk_view instead of ewk_view for readability ?

Thanks for pointing that out.
I notice that if I use the window->ewk_view then the scroll event is not consumed by the view. So scrolling still remains active along with zoom.

To avoid this we should use the ewk_view instance passed back in the parameter so that the framework knows that event has been consumed. I have made this uniform and I am using ewk_view for all the API calls in on_mouse_wheel callback.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list