[Webkit-unassigned] [Bug 136855] [Curl] Sometimes incomplete or empty content can be loaded from cache.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 16 11:39:07 PDT 2014


--- Comment #7 from peavo at outlook.com  2014-09-16 11:39:08 PST ---
(In reply to comment #5)
> (From update of attachment 238184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238184&action=review
> This looks mostly good.  r- only because it needs another patch and I have a question.

Thanks for the review :) I have updated the patch.

> > Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:119
> > +    if (buffer.size() > 0)
> is buffer.size() signed?  I think this should just be if (buffer.size()).
> > Source/WebCore/platform/network/curl/CurlCacheManager.cpp:221
> > +            cacheEntry->setIsLoading(true);
> This not only sets the loading flag, but it calls openContentFile.  Is this intentional?

Yes, when there are responses with only headers, and no content, we need to create the content file (which will be empty). Otherwise it will never be created since we never receive any content data. When another request for the same url tries to retrieve the content data from the cache, the file will not exist, and the request will fail.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list