[Webkit-unassigned] [Bug 136855] [Curl] Sometimes incomplete or empty content can be loaded from cache.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136855


Alex Christensen <alex.christensen at flexsim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238184|review?                     |review-
               Flag|                            |




--- Comment #5 from Alex Christensen <alex.christensen at flexsim.com>  2014-09-16 11:24:44 PST ---
(From update of attachment 238184)
View in context: https://bugs.webkit.org/attachment.cgi?id=238184&action=review

This looks mostly good.  r- only because it needs another patch and I have a question.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:119
> +    if (buffer.size() > 0)

is buffer.size() signed?  I think this should just be if (buffer.size()).

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:221
> +            cacheEntry->setIsLoading(true);

This not only sets the loading flag, but it calls openContentFile.  Is this intentional?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.