[Webkit-unassigned] [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136818


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238124|review?                     |review-
               Flag|                            |




--- Comment #10 from chris fleizach <cfleizach at apple.com>  2014-09-16 10:27:44 PST ---
(From update of attachment 238124)
View in context: https://bugs.webkit.org/attachment.cgi?id=238124&action=review

still need to figure out the layout test failures. otherwise the concept seems ok

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:127
> +    while (parentNode) {

we should add some comments here to explain why we want to do this

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:147
> +        if (parentNode->hasTagName(tbodyTag) || parentNode->hasTagName(tfootTag))

we should add some comments here to explain why we want to do this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.