[Webkit-unassigned] [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136818





--- Comment #6 from chris fleizach <cfleizach at apple.com>  2014-09-15 09:04:55 PST ---
(From update of attachment 238124)
View in context: https://bugs.webkit.org/attachment.cgi?id=238124&action=review

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:140
> +    if (scope == "row" || scope == "rowgroup")

It seems like this will invalidate the existing logic
if ("rowgroup" && isTableCellInSameRowGroup(tableCell)

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:145
> +    while (parentNode) {

this should be written as a for loop. 
also, you're getting the parentNode at a bad time, because when the parentNode() returns 0, you'll then crash on the next line
   if (parentNode->hasTagName(...

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:146
> +        parentNode = parentNode->parentNode();

what is the provenance of this logic? Is there something in the spec that says a cell in a tfooter or body is a row header?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.