[Webkit-unassigned] [Bug 131704] Simple ES6 feature:String prototype additions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 12 12:32:36 PDT 2014


--- Comment #40 from Diego Pino <dpino at igalia.com>  2014-09-12 12:32:37 PST ---
Thanks Darin for the extensive review. I uploaded a new version of the patch with most of the last issues fixed.

I don't know why, while commenting your last review I repeated the comment about "const StringImpl&". Finally I managed to remove the 'const' modifier. I const_cast<StringImpl&>(*this). I don't know what's best.

There are still some issues pending to be clarified, so I didn't cq? the patch. Mostly we need to agree whether to leave the order of the parameters in 'contains' as it is, or instead, do not overload 'contains', 'startsWith' and 'endsWith' and add these functions with other names, that will give more freedom (and avoid any problem or error with the compiler warnings because of ambiguity). Each approach has its pros and cons. If we opted for the first approach a refactoring will be desired, but likely in another patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list