[Webkit-unassigned] [Bug 136734] Check for varying packing restrictions per program instead of per shader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136734


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237961|review?                     |review+
               Flag|                            |




--- Comment #5 from Dean Jackson <dino at apple.com>  2014-09-11 11:50:18 PST ---
(From update of attachment 237961)
View in context: https://bugs.webkit.org/attachment.cgi?id=237961&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:368
> +        const char* builtIns[] = {
> +            "gl_FragCoord",
> +            "gl_FrontFacing",
> +            "gl_PointCoord"
> +        };
> +
> +        bool isBuiltIn = false;
> +        for (int i = 0; i < 3; ++i) {
> +            if (symbolName == builtIns[i]) {
> +                isBuiltIn = true;
> +                break;
> +            }
> +        }
> +
> +        if (isBuiltIn)
> +            continue;

I don't really have a preference here, but maybe it might be simpler to do if (symbolName == "gl_FragCoord" || symbolName ==...) continue;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.