[Webkit-unassigned] [Bug 136736] [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136736





--- Comment #4 from Rohit <kumar.rohit at samsung.com>  2014-09-11 02:05:54 PST ---
(In reply to comment #2)
> (From update of attachment 237937 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237937&action=review
> 
> > Tools/MiniBrowser/efl/main.c:1891
> > +    Ewk_Navigation_Policy_Decision* decision = (Ewk_Navigation_Policy_Decision*)event_info;
> 
> Wrong * place. Missing a space between "(Ewk_Navigation_Policy_Decision" and "*)"
> 

Done.

> > Tools/MiniBrowser/efl/main.c:1900
> > +        ewk_navigation_policy_decision_reject(decision); 
> 
> Doesn't we call ewk_navigation_policy_decision_accept() ? And It looks we need to call this reject function when ewk_navigation_policy_mouse_button_get(decision) is not EWK_EVENT_MOUSE_BUTTON_MIDDLE, isn't it ?

As per the bug https://bugs.webkit.org/show_bug.cgi?id=90953
by default the navigation request is accepted. So I think there is no need to call ewk_navigation_policy_decision_accept().
Also if we call reject function when ewk_navigation_policy_mouse_button_get(decision) is not EWK_EVENT_MOUSE_BUTTON_MIDDLE, then we will not be able to navigate to any page for all cases other than mouse middle button case. And adding reject at the end makes sure that we do not open the same page in parent and child window.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.