[Webkit-unassigned] [Bug 136736] [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136736





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-09-10 23:44:44 PST ---
(From update of attachment 237937)
View in context: https://bugs.webkit.org/attachment.cgi?id=237937&action=review

> Tools/MiniBrowser/efl/main.c:1891
> +    Ewk_Navigation_Policy_Decision* decision = (Ewk_Navigation_Policy_Decision*)event_info;

Wrong * place. Missing a space between "(Ewk_Navigation_Policy_Decision" and "*)"

> Tools/MiniBrowser/efl/main.c:1900
> +        ewk_navigation_policy_decision_reject(decision); 

Doesn't we call ewk_navigation_policy_decision_accept() ? And It looks we need to call this reject function when ewk_navigation_policy_mouse_button_get(decision) is not EWK_EVENT_MOUSE_BUTTON_MIDDLE, isn't it ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.