[Webkit-unassigned] [Bug 136701] NetworkResourceLoader cleanups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 10 09:58:45 PDT 2014


--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2014-09-10 09:58:48 PST ---
(From update of attachment 237890)
View in context: https://bugs.webkit.org/attachment.cgi?id=237890&action=review

> Source/WebKit2/ChangeLog:21
> +            Instead of copying everything out from NetworkResourceLoadParameters just include the whole thing as a const field.

I guess it's OK to try how this feels, but this is not how other "parameters" classes work, and it's really a layering violation between IPC and loading logic to do this.

> Source/WebKit2/ChangeLog:64
> +            Use original request instead of the current one. This might fix a bug where we didn't use file backing over redirects.

I'd love to hear Brady's take on this. To me, this sounds incorrect - caching is always about the final URL, because redirect chains can and do change.

> Source/WebKit2/ChangeLog:69
> +            Decode to SanboxExtensions to the actual type rather than a handle.

Good stuff - the complications with sandbox extensions were caused by lack of C++11 move support at the time the code was written, and the class itself wasn't RefCounted if I remember correctly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list