[Webkit-unassigned] [Bug 136701] NetworkResourceLoader cleanups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136701


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237890|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2014-09-10 09:13:25 PST ---
(From update of attachment 237890)
View in context: https://bugs.webkit.org/attachment.cgi?id=237890&action=review

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.h:78
> +    const WebCore::ResourceRequest& originalRequest() const { return m_parameters.request; }
> +    // Changes with redirects.
> +    WebCore::ResourceRequest& currentRequest() { return m_currentRequest; }

The paragraphing here made it hard for me to understand the comment. I would put a blank line before the comment.

> Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp:133
> +        for (size_t i = 0, count = requestBodySandboxExtensionHandles.size(); i < count; ++i) {

Modern for loop would be better.

> Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp:135
> +                result.requestBodySandboxExtensions.append(extension);

extension.release()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.