[Webkit-unassigned] [Bug 136692] Race condition with WebKitWebView:is-loading after starting page load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136692





--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org>  2014-09-10 06:20:24 PST ---
(In reply to comment #2)
> (From update of attachment 237878 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237878&action=review
> 
> I also started with this, I have a wip patch in my local repo, but it's blocked by other differences between our API and the internal one regarding the active URL.

Do you want me to keep working on this then?

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:102
> > +    RefPtr<WebKitPageLoadObserver> pageLoadObserver;
> 
> I don't think this should be in WebKitWebViewBase, but in WebKitWebView.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1011
> > +    priv->pageLoadObserver = WebKitPageLoadObserver::create(*WEBKIT_WEB_VIEW(webkitWebViewBase), priv->pageProxy->pageLoadState());
> 
> It's not correct to cast the webkitWebViewBase as WebKitWebView here.

The problem is that I'm not sure when else it is safe to add the page load observer, except when the WebKitWebViewBase creates a new page?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.