[Webkit-unassigned] [Bug 136690] New: Web Inspector: Fix ESLint* no-avoidable-bind warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 18:13:34 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=136690

           Summary: Web Inspector: Fix ESLint* no-avoidable-bind warnings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com,
                    jonowells at apple.com, graouts at webkit.org


I wrote an ESLint rule to catch avoidable Function.prototype.bind call with a number of built-in Array/Set/Map functional methods and it caught some issues in our code:
https://github.com/JosephPecoraro/eslint/commit/d64243a312b4e872bc3e63ccfa6ad84d2a29c675

UserInterface/Protocol/RemoteObject.js
  358:35  error  Function binding is avoidable. Use the optional thisArg argument of 'map'  no-avoidable-bind

UserInterface/Views/CSSStyleDetailsSidebarPanel.js
  47:8  error  Function binding is avoidable. Use the optional thisArg argument of 'forEach'  no-avoidable-bind

UserInterface/Views/LayerTreeSidebarPanel.js
  269:8  error  Function binding is avoidable. Use the optional thisArg argument of 'forEach'  no-avoidable-bind
  277:8  error  Function binding is avoidable. Use the optional thisArg argument of 'forEach'  no-avoidable-bind
  283:8  error  Function binding is avoidable. Use the optional thisArg argument of 'forEach'  no-avoidable-bind

UserInterface/Views/LogContentView.js
  646:8  error  Function binding is avoidable. Use the optional thisArg argument of 'forEach'  no-avoidable-bind

UserInterface/Views/TextResourceContentView.js
  90:22  error  Function binding is avoidable. Use the optional thisArg argument of 'filter'  no-avoidable-bind

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list