[Webkit-unassigned] [Bug 136219] Websocket state should be set to closed in didReceiveMessage call back

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 9 00:06:49 PDT 2014


--- Comment #7 from Shivakumar J M <shiva.jm at samsung.com>  2014-09-09 00:06:46 PST ---
(In reply to comment #6)
> (From update of attachment 237144 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237144&action=review
> >>> Source/WebCore/Modules/websockets/WebSocket.cpp:536
> >>> +    m_state = CLOSED;
> >> 
> >> Do we also need to call m_channel->disconnect()? Do we also need to call ActiveDOMObject::unsetPendingActivity?
> > 
> > Dear Darin,
> > 
> >      Thanks for inputs, i rechecked again, i think we no need to close the channel object here, also ActiveDOMObject.
> I’m glad you think so. Why do you think so?

Dear Darin,

Here is my analysis, When i ran the new test cases error-event-ready-state.html, first we get onerror() call back, where the proper state will be set, after these onclose() will get called, so here the channel object will get closed and ActiveDOMObject as well. so we no need to release the resources in didReceiveMessageError() call back.

I tried by closing channel object in didReceiveMessageError() call back. but it was failing some other tests, with error: FAIL: Timed out waiting for notifyDone to be called.

pls share your inputs, if my understanding is not correct.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list