[Webkit-unassigned] [Bug 136667] [WebKit2] Fix build error in WebKit2/WebProcess module

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 8 22:43:58 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=136667


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237841|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2014-09-08 22:43:59 PST ---
(From update of attachment 237841)
View in context: https://bugs.webkit.org/attachment.cgi?id=237841&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:116
> +    default:
> +        return 0_ms;

We don’t want a default here, because that will disable the warning that clang and other compilers give us when we forget to handle a case. Instead, we should put this return statement outside the switch, and we should also include ASSERT_NOT_REACHED.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list