[Webkit-unassigned] [Bug 135965] Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135965





--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org>  2014-09-08 14:25:37 PST ---
(In reply to comment #7)
> (From update of attachment 236678 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236678&action=review
> 
> > Source/WebInspectorUI/UserInterface/Base/Main.js:871
> >  WebInspector._pageHidden = function(event)
> >  {
> > -    this._updateCookieForInspectorViewState();
> > +    // FIXME: pagehide events are not firing at the correct time.
> > +    // Ignore the event for now, and instead update view state
> > +    // every time the ContentView changes instead of only when we close.
> > +    // this._updateCookieForInspectorViewState();
> >  }
> 
> Unregister the event, remove the function and just file a bug?

Hmm, interestingly this is working for me now. I decided to keep this and NOT update view state on every content view change. Things are working well for now.


> > Source/WebInspectorUI/UserInterface/Base/Main.js:926
> > +    // FIXME: Selecting a CallFrameTreeElement selects the resource, does the code below work?
> 
> Good catch. For the Debugger sidebar panel, which has two content tree outlines, selectedSidebarPanel.contentTreeOutline.processingSelectionChange is the wrong check.

I'll take a look at this now.


> The check should iterate over _visibleContentTreeOutlines and look for processingSelectionChange on any of them.
> 
> > Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:684
> > +        if (!this._pendingViewStateCookie) {
> > +            if (this._viewStateCookieMatchingRepresentedObject && !Array.isArray(treeElements) && treeElements.representedObject === this._viewStateCookieMatchingRepresentedObject) {
> > +                treeElements.revealAndSelect();
> > +                delete this._viewStateCookieMatchingRepresentedObject;
> > +            }
> >              return;
> > +        }
> 
> We talked about a better fox for this in FrameTreeElement.

Yep, this is much nicer. It does less work too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.