[Webkit-unassigned] [Bug 136372] [GTK] allow overwriting destination of download

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 6 15:40:40 PDT 2014


--- Comment #13 from Michael Catanzaro <mcatanzaro at gnome.org>  2014-09-06 15:40:41 PST ---
(In reply to comment #12)
> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:-222
> > -    void receivedResponse(WebKitDownload* download)
> > -    {
> > -        DownloadTest::receivedResponse(download);
> > -    }
> Why did you delete this?

I guess I should not have in this patch, since it's not related. I removed it because it wasn't doing anything (it's an override of a virtual function that just calls the parent class's version of that function).

> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:288
> > +    test->m_permitSuccess = false;
> I don't think this is working, this combination makes the test set an invalid destination in decideDestination(), so this will fail because of the invalid destination and not because of the destination file already exists.

Yes, this test was really broken, sorry.

> I've noticed we are using this in all download error tests, but I guess we should check the files don't exist at this
> point, since they are supposed to be deleted by the web process when the download fails or is cancelled.

Well, if the download fails because the file already exists, as would be the case here, that wouldn't make sense.  But it would be good for the other test cases, yes.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list