[Webkit-unassigned] [Bug 136571] Remove FILTERS flag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136571





--- Comment #2 from Csaba Osztrogonác <ossy at webkit.org>  2014-09-05 05:49:51 PST ---
(From update of attachment 237683)
View in context: https://bugs.webkit.org/attachment.cgi?id=237683&action=review

> Source/WebCore/platform/graphics/filters/DistantLightSource.cpp:-33
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)

Please remove this empty line here and 
in all filters/*.cpp

> Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:-23
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)

ditto

> Source/WebCore/svg/SVGFEBlendElement.cpp:-24
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)

ditto

> Source/WebCore/svg/SVGFEColorMatrixElement.cpp:-23
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)

ditto

> Source/WebCore/svg/SVGFEComponentTransferElement.cpp:-23
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)

ditto ... and in all SVGFE*.cpp

> Source/WebCore/svg/SVGFEDistantLightElement.cpp:23
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)
>  #include "SVGFEDistantLightElement.h"
>  #include "SVGNames.h"

#include "config.h"
#include "SVGFEDistantLightElement.h"

#include "SVGNames.h"

> Source/WebCore/svg/SVGFEFuncAElement.cpp:24
>  #include "config.h"
>  
> -#if ENABLE(FILTERS)
>  #include "SVGFEFuncAElement.h"
>  #include "SVGNames.h"

ditto

> Tools/Scripts/webkitperl/FeatureList.pm:-234
> -    { option => "filters", desc => "Toggle Filters support",
> -      define => "ENABLE_FILTERS", default => (isAppleWebKit() || isIOSWebKit() || isGtk() || isEfl()), value => \$filtersSupport },
> -

Please remove the $filtersSupport variable too. (and the leftover $cssFiltersSupport variable too)

> LayoutTests/platform/ios-sim/Skipped:743
> -# FIXME: <rdar://problem/8987731> iOS: Update/unskip SVG tests after turning on ENABLE_FILTERS
> +# FIXME: <rdar://problem/8987731> iOS: Update/unskip SVG tests

I don't think if we should change this comment, but iOS maintainers should unskip these tests if they are passing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.