[Webkit-unassigned] [Bug 136542] Web Inspector: breakpoint actions should work regardless of Content Security Policy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136542





--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2014-09-04 19:36:23 PST ---
(From update of attachment 237670)
View in context: https://bugs.webkit.org/attachment.cgi?id=237670&action=review

Looks good to me.

> Source/JavaScriptCore/debugger/DebuggerEvalEnabler.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Nit: 2014

> LayoutTests/inspector/debugger/breakpoint-action-eval.html:22
> +    WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, function() {

Is the MainResourceDidChange + reload really necessary? This test would be much simpler if it was just listening for the ScriptAdded event.

> LayoutTests/inspector/debugger/breakpoint-action-eval.html:39
> +          });

Nit: broken indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.