[Webkit-unassigned] [Bug 136507] New: Make images work with patches created using svn 1.7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 15:17:50 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=136507

           Summary: Make images work with patches created using svn 1.7
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: hyatt at apple.com, simon.fraser at apple.com,
                    dbates at webkit.org, dfarler at apple.com


Subversion 1.7 does this crazy thing where it emits a text patch for the property changes of a newly added image, immediately after the original "diff" header:

Index: simple-gradients-expected.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: simple-gradients-expected.png
===================================================================
--- simple-gradients-expected.png    (revision 0)
+++ simple-gradients-expected.png    (working copy)

Property changes on: simple-gradients-expected.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

This greatly confuses PrettyPatch.rb because the first patch looked like the image was being removed, and the second patch looked like normal diff (until the blank line and the property changes are hit).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list