[Webkit-unassigned] [Bug 136473] Avoid warning if a process does not have access to com.apple.webinspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 11:43:24 PDT 2014


--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2014-09-03 11:43:28 PST ---
(In reply to comment #5)
> > > In any case, sandbox_check declaration should not be inside the #else.
> > 
> > I don't follow. Why not?
> This way, we'll get a compile error internally if the function signature changes in the future. That's much better than having to chase a mysterious behavior difference between internal and open source builds.

Internally we should just get the include, so if the signature changes we would fail immediately. If the file changes, then we'd be out of luck.

    #if __has_include(<sandbox/private.h>)
    #import <sandbox/private.h>

I think we have to put some signature in the else, so that open source developers can compile the file. This pattern is repeated in a couple places (WebKit2).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list