[Webkit-unassigned] [Bug 115149] Implement ruby-align

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 03:58:02 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=115149





--- Comment #8 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2014-09-03 03:58:06 PST ---
I changed the following from the old patch:
1. Removed auto, left, end and right value
2. Removed line-edge value and related code
3. Checked ruby-align of RenderRubyBase and RenderRubText, not of RenderRuby

Detail description:
1. Removed auto, left, end and right

The newer spec removed these values.

2. Removed line-edge and related code

The newer spec removed these values. This made me able to remove isStartEdge() and isEndEdge() code.

3. Checked ruby-align of RenderRubyBase and RenderRubText, not of RenderRuby

The newer spec says that ruby-align only apply to ruby bases, ruby annotations, ruby base containers, ruby annotation containers.
This is very different from IE's behavior which the test case in the old patch checks. However, I changed to match with the new spec. This change allow to remove getRubyAlignFromRenderRuby() and make the code simpler.
Since currently RenderRubyBase is not created from rb element, setting ruby-align to rb element is just ignored.
I also removed IE compatibility test from the layout test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list