[Webkit-unassigned] [Bug 136477] [GTK] run-webkit-test check for jhBuild is not correct

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136477


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com




--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2014-09-03 03:06:30 PST ---
(In reply to comment #0)
> Tools/Scripts/webkitpy/port/gtk.py is checking if tests must be run within jhBuild wrapper. 
> If webkit/WebKitBuild/Dependencies exists, tests are run using jhBuild wrapper - it works fine using default configuration, however it has 2 issues:
> 
> 1) WebKitBuild/Dependencies exists even if jhBuild is not used, because it is needed for fonts (as you can see in getFontsPath() method from http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp)
> So a build using default WebKitBuild folder but NOT using jhBuild will be using jhBuild wrapper anyway (and jhBuild checkout during tests mess up everything).
> 

But if you set WEBKIT_OUTPUTDIR and don't have Dependencies/ that function will look for fonts in WEBKIT_OUTPUTDIR, or am I misunderstanding that code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.