[Webkit-unassigned] [Bug 136477] New: [GTK] run-webkit-test check for jhBuild is not correct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 3 02:01:40 PDT 2014


           Summary: [GTK] run-webkit-test check for jhBuild is not correct
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fvallee at connected-labs.com

Tools/Scripts/webkitpy/port/gtk.py is checking if tests must be run within jhBuild wrapper. 
If webkit/WebKitBuild/Dependencies exists, tests are run using jhBuild wrapper - it works fine using default configuration, however it has 2 issues:

1) WebKitBuild/Dependencies exists even if jhBuild is not used, because it is needed for fonts (as you can see in getFontsPath() method from http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp)
So a build using default WebKitBuild folder but NOT using jhBuild will be using jhBuild wrapper anyway (and jhBuild checkout during tests mess up everything).

2) build folder (default is webkit/WebKitBuild) can be overridden using WEBKIT_OUTPUTDIR env variable. In that case jhBuild is never detected and regression tests will fail (tests are using system libs instead of jhBuild)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list