[Webkit-unassigned] [Bug 136473] Avoid warning if a process does not have access to com.apple.webinspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136473


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237539|review?                     |review+
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2014-09-02 18:54:43 PST ---
(From update of attachment 237539)
View in context: https://bugs.webkit.org/attachment.cgi?id=237539&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:59
> +#if __has_include(<sandbox/private.h>)
> +#import <sandbox/private.h>
> +#else
> +enum sandbox_filter_type {
> +    SANDBOX_FILTER_GLOBAL_NAME,
> +};
> +extern "C" {
> +int sandbox_check(pid_t, const char *operation, enum sandbox_filter_type, ...);
> +}
> +#endif

Sandbox SPIs seem like a prime target for the new technique Maciej is suggesting, as we use them in many places. Instead of declaring the SPIs in each .mm file, they would go into SandboxSPI.h.

In any case, sandbox_check declaration should not be inside the #else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.